Deprecate Default/Kotlin LifecycleScopeProvider interfaces #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure this is accurate. This depends on how build systems implement it. re-dexing of implementers only needs to happen if abi changes occur in D8. Not sure how the kotlin version works (I would guess the desugaring to be similar) |
if you change an interface, isn't that an ABI change? Yes it is |
ZacSweers
force-pushed
the
z/defaultLifecycleScopeProvider
branch
from
c3980c1
to
be39cb9
Compare
|
Want to update the sample recipes as well? |
ShaishavGandhi
approved these changes
Dec 13, 2018
|
I couldn't find any major build issue. At the end of the day, this would only be an issue if the interface of LifecycleScopeProvider changed, which would only be in new dependency updates and should cause a rebuild anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's look at just unifying this into the base class instead
TODO: benchmark kotlin's default method compilation effects compared to D8's for
defaultones, as the latter can have significant build time penalties since it requires recompilation of all implementersIf anyone in the community wants to try this out and let us know, please do!